netdev - Re: [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A6B376.4010507@jp.fujitsu.com>
Date:	Tue, 26 Jan 2016 08:44:54 +0900
From:	Yuki Machida <machida.yuki@...fujitsu.com>
To:	netdev@...r.kernel.org
Cc:	gregkh@...uxfoundation.org,
	Salva Peiró <speirofr@...il.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>
Subject: Re: [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl

It has sent to the wrong Mainling List.
sorry.

On 2016年01月25日 19:42, Yuki Machida wrote:
> commit eda98796aff0d9bf41094b06811f5def3b4c333c upstream.
>
> The vivid_fb_ioctl() code fails to initialize the 16 _reserved bytes of
> struct fb_vblank after the ->hcount member. Add an explicit
> memset(0) before filling the structure to avoid the info leak.
>
> This fixes CVE-2015-7884.
>
> Signed-off-by: Salva Peiró <speirofr@...il.com>
> Signed-off-by: Hans Verkuil <hans.verkuil@...co.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@....samsung.com>
> Signed-off-by: Yuki Machida <machida.yuki@...fujitsu.com>
> ---
>   drivers/media/platform/vivid/vivid-osd.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/vivid/vivid-osd.c b/drivers/media/platform/vivid/vivid-osd.c
> index 084d346..e15eef6 100644
> --- a/drivers/media/platform/vivid/vivid-osd.c
> +++ b/drivers/media/platform/vivid/vivid-osd.c
> @@ -85,6 +85,7 @@ static int vivid_fb_ioctl(struct fb_info *info, unsigned cmd, unsigned long arg)
>   	case FBIOGET_VBLANK: {
>   		struct fb_vblank vblank;
>
> +		memset(&vblank, 0, sizeof(vblank));
>   		vblank.flags = FB_VBLANK_HAVE_COUNT | FB_VBLANK_HAVE_VCOUNT |
>   			FB_VBLANK_HAVE_VSYNC;
>   		vblank.count = 0;
>