netdev - Re: [RFC PATCH v2] ethtool: add IPv6 to the NFC API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 03:20:52 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Edward Cree <ecree@...arflare.com>,
	Alexander Duyck <alexander.duyck@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH v2] ethtool: add IPv6 to the NFC API

On Fri, 2016-01-22 at 18:04 +0000, Edward Cree wrote:
[...]
>  #define	IP_USER_FLOW	0x0d	/* spec only (usr_ip4_spec) */
> +#define	IP6_USER_FLOW	0x0e	/* spec only (usr_ip6_spec; nfc only) */
[...]

This should be named IPV6_USER_FLOW for consistency with the other NFC
type names.  It might also be worth adding IPV4_USER_FLOW as an alias
for IP_USER_FLOW.

Otherwise this looks fine.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy others.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)