netdev - Re: [PATCH 16/26] libceph: Use skcipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2016 17:18:47 +0100
From:	Ilya Dryomov <idryomov@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>, devel@...verdev.osuosl.org,
	dm-devel@...hat.com, linux-wireless@...r.kernel.org,
	linux-cifs@...r.kernel.org, ecryptfs@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
	linux-nfs@...r.kernel.org, keyrings@...r.kernel.org,
	linux-bluetooth@...r.kernel.org,
	Ceph Development <ceph-devel@...r.kernel.org>,
	linux-wpan@...r.kernel.org, linux-afs@...ts.infradead.org,
	Lars Ellenberg <drbd-dev@...ts.linbit.com>,
	open-iscsi@...glegroups.com
Subject: Re: [PATCH 16/26] libceph: Use skcipher

On Sun, Jan 24, 2016 at 2:18 PM, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> This patch replaces uses of blkcipher with skcipher.
>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> ---
>
>  net/ceph/crypto.c |   97 +++++++++++++++++++++++++++++++-----------------------
>  1 file changed, 56 insertions(+), 41 deletions(-)

Could you get rid of ivsize instead of assigning to it - see the
attached diff?

Otherwise:

Acked-by: Ilya Dryomov <idryomov@...il.com>

Thanks,

                Ilya

View attachment "skcipher-ivsize.diff" of type "text/plain" (7703 bytes)