netdev - Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1453741769.11327.0.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 25 Jan 2016 09:09:29 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:	netdev@...r.kernel.org, "K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	David Miller <davem@...emloft.net>,
	Tom Herbert <tom@...bertland.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Subject: Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a
 homegrown implementation

On Mon, 2016-01-25 at 16:00 +0100, Vitaly Kuznetsov wrote:
> Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add
> VLAN ID to flow_keys")) introduced a performance regression in netvsc
> driver. Is problem is, however, not the above mentioned commit but the
> fact that netvsc_set_hash() function did some assumptions on the struct
> flow_keys data layout and this is wrong.
> 
> Get rid of netvsc_set_hash() by switching to skb_get_hash(). This change
> will also imply switching to Jenkins hash from the currently used Toeplitz
> but it seems there is no good excuse for Toeplitz to stay.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks !