lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56A71262.8000804@gmail.com> Date: Tue, 26 Jan 2016 07:29:54 +0100 From: Arend van Spriel <aspriel@...il.com> To: Julian Calaby <julian.calaby@...il.com> Cc: Sjoerd Simons <sjoerd.simons@...labora.co.uk>, Kalle Valo <kvalo@...eaurora.org>, Paul Stewart <pstew@...omium.org>, Doug Anderson <dianders@...omium.org>, linux-rockchip@...ts.infradead.org, Arend van Spriel <arend@...adcom.com>, Pieter-Paul Giesberts <pieterpg@...adcom.com>, brcm80211-dev-list@...adcom.com, linux-wireless <linux-wireless@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Hante Meuleman <meuleman@...adcom.com>, Brett Rudley <brudley@...adcom.com>, netdev <netdev@...r.kernel.org>, "Franky (Zhenhui) Lin" <frankyl@...adcom.com> Subject: Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit On 26-01-16 00:41, Julian Calaby wrote: > Hi Arend, > > On Tue, Jan 26, 2016 at 2:39 AM, Arend van Spriel <aspriel@...il.com> wrote: >> On 25-01-16 12:06, Julian Calaby wrote: >>> Hi Sjoerd, >>> >>> On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons >>> <sjoerd.simons@...labora.co.uk> wrote: >>>> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems >>>> the card responds very quickly most of the time, unfortunately during >>>> initialisation it sometimes seems to take just a bit over 2 seconds to >>>> respond. >>>> >>>> This results intialization failing with message like: >>>> brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52 >>>> brcmf_bus_start: failed: -52 >>>> brcmf_sdio_firmware_callback: dongle is not responding >>>> >>>> Increasing the timeout to allow for a bit more headroom allows the >>>> card to initialize reliably. >>>> >>>> A quick search online after diagnosing/fixing this showed that Google >>>> has a similar patch in their ChromeOS tree, so this doesn't seem >>>> specific to the board I'm using. >>>> >>>> Signed-off-by: Sjoerd Simons <sjoerd.simons@...labora.co.uk> >>> >>> Looks sane to me. >>> >>> Reviewed-by: Julian Calaby <julian.calaby@...il.com> >> >> Not really a cleanup patch :-p , but thanks for the review. > > I'm trying to review any "small" patch from (relatively) new people. And it is surely appreciated. Just read your reply in "cleanup patch pile" thread and felt I had to make the stupid remark with just fun intended. Regards, Arend
Powered by blists - more mailing lists