lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGRGNgXSbo1ZjFda5qyg8cesddTSUO2=rMEsopzHDuVBpHJqaA@mail.gmail.com> Date: Wed, 27 Jan 2016 10:15:57 +1100 From: Julian Calaby <julian.calaby@...il.com> To: Cong Wang <xiyou.wangcong@...il.com> Cc: netdev <netdev@...r.kernel.org>, Dmitry Vyukov <dvyukov@...gle.com>, linux-wireless <linux-wireless@...r.kernel.org>, Lauro Ramos Venancio <lauro.venancio@...nbossa.org>, Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>, Samuel Ortiz <sameo@...ux.intel.com> Subject: Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc Hi Cong, On Wed, Jan 27, 2016 at 10:12 AM, Cong Wang <xiyou.wangcong@...il.com> wrote: > On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby <julian.calaby@...il.com> wrote: >> Hi Cong, >> >> On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang <xiyou.wangcong@...il.com> wrote: >> >> A commit message would be nice. A brief rundown of how this is called >> from userspace would be nice (I'm talking a single sentence here, e.g. >> "this is allocated when submitting a nfc packet") and what issue >> __GFP_NOWARN is fixing. (I'm guessing log spam due to allocation >> failures.) >> > > I thought it is obvious. ;) Keep in mind that $subject is one part of commit > message too, so there is a commit message although very short. > > I will add it. I know almost nothing about how the NFC subsystem works, and this looks like a potential security issue, so more information is better IMHO. Thanks, -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists