netdev - Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160127015755.GB4815@lunn.ch>
Date:	Wed, 27 Jan 2016 02:57:55 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, aaro.koskinen@...ia.com,
	olof@...om.net
Subject: Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

> Well, we do now, since that is one of the results used by
> of_mdiobus_child_is_phy(),

It uses it, but do not rely on it, since for backwards compatibility,
we cannot assume it is there.

You can never change an optional parameter to a mandatory parameter in
DT. To do so breaks backwards compatibility.

> What I would prefer seeing though is not removing nodes that have at
> least two compatible strings, including one that is
> "ethernet-phy-ieee802.3-c22", but those which have only one, like the
> marvell ones that you patch, should have either an additional
> "ethernet-phy-ieee802.3-c22", or none.

So you are saying, if there is an "ethernet-phy-ieee802.3-c22" or an
"ethernet-phy-ieee802.3-45" you can also have any other random junk,
which we are going to ignore, since we have no way to verify, hence we
have to assume it is broken, yet we need to be backwards compatible
with it.

Did you notice:

+       { .compatible = "marvell,88e1310", },
+       { .compatible = "marvell,88E1510", },

No consistency with the 'e'. We would just be encouraging people to
add more inconsistent stuff.

    Andrew