netdev - Re: [PULL] virtio: fixes, tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzC6mopLkYYvuZNK8W510MpqgSuYwhjAAM-XeuAdEfs3A@mail.gmail.com>
Date:	Wed, 27 Jan 2016 14:57:28 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Michael S. Tsirkin" <mst@...hat.com>,
	Junio C Hamano <gitster@...ox.com>
Cc:	KVM list <kvm@...r.kernel.org>,
	virtualization <virtualization@...ts.linux-foundation.org>,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	jmarchan@...hat.com, Kamal Mostafa <kamal@...onical.com>,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: [PULL] virtio: fixes, tests

On Wed, Jan 27, 2016 at 2:15 PM, Michael S. Tsirkin <mst@...hat.com> wrote:
>>
>> Anyway, pulled. Just curious about how that thing happened.
>
> That's because apparently diffstat obeys orderfile rules:

Ugh. I guess that makes sense, but it's still very annoying for
something like a pull request, where now different people end up
having different diffstats. And the reason I never noticed it is that
likely there aren't that many people who use an orderfile.

I guess something like "-O /dev/null" in the pull-request would undo
it, but it is a bit annoying.

I've never actually met anybody (knowingly) that used that option. I
thought it was a Junio-only use case (it's been around forever as a
command line option, but the config file entry seems to be somewhat
recent and I wasn't even aware of it).

Adding Junio just as background to see what he thinks. Looks like the
diff.orderfile config option hits not just porcelain, but plumbing
too.

              Linus