netdev - Re: [PATCH net 1/2] of: of_mdio: Add a whitelist of PHY compatibilities.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160127140350.GA18319@lunn.ch>
Date:	Wed, 27 Jan 2016 15:03:50 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	aaro.koskinen@...ia.com, olof@...om.net
Subject: Re: [PATCH net 1/2] of: of_mdio: Add a whitelist of PHY
 compatibilities.

On Wed, Jan 27, 2016 at 04:51:38PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 01/27/2016 03:11 AM, Andrew Lunn wrote:
> 
> >Some phy nodes list a compatible value indicating the PHY make/model.
> >This is never used to match the device to the driver. However it does
> >confuse the code to separate a PHY from a generic MDIO device like a
> >switch. Generic MDIO devices must have a compatible value, PHYs can
> >list clause 22 or 45, but nothing else.
> >
> >Issue a warning if we find a compatible value known on the whitelist,
> 
>    My spell-checker trips on "whitelist"... Perhaps a space/hyphen needed?

$ dict whitelist
1 definition found

>From The Jargon File (version 4.4.7, 29 Dec 2003) [jargon]:

  whitelist
   n.
  
          The opposite of a blacklist. That is, instead of being an explicit
          list of people who are banned, it's an explicit list of people who
          are to be admitted. Hackers use this especially of lists of email
          addresses that are explicitly enabled to get past strict anti-spam
          filters.

> >+/* The following is a list of PHY compatible strings which appear in
> >+ * some DTBs. The compatible string is never matched against a PHY
> >+ * driver, so is pointless. We only expect devices which are not PHYs
> >+ * to have a compatible string, so they can be matched to an MDIO
> >+ * driver.  Encourage users to upgrade there DT blobs to remove these.
> 
>    s/there/their/.

I will fix this.

  Andrew