netdev - Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160127010638.GA4815@lunn.ch>
Date:	Wed, 27 Jan 2016 02:06:38 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, aaro.koskinen@...ia.com,
	olof@...om.net
Subject: Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

On Tue, Jan 26, 2016 at 04:33:11PM -0800, Florian Fainelli wrote:
> On 26/01/16 16:11, Andrew Lunn wrote:
> > PHY devices may only list clause 22, 45, and their PHY identifier
> > values as compatible values. No other compatible strings are allowed.
> > Make this clear in the documentation, and remove examples where
> > make/model compatible strings are listed.
> 
> Humm, should not we rather require Ethernet PHY Device Tree nodes to
> have *at least* a "ethernet-phy-ieee802.3-c22" or
> "ethernet-phy-ieee802.3-c45", and any other compatible string which
> further specifies the hardware is also welcome?

At the moment, "ethernet-phy-ieee802.3-c45" is used, we look for it
and act upon it. "ethernet-phy-ieee802.3-c22" is not used anywhere,
other than my new of_mdiobus_child_is_phy(). Also, for backwards
compatibility with older blobs, we can never assume one or the other
will be present.

So you are suggesting we change around 200 ethphy nodes to add in
"ethernet-phy-ieee802.3-c22", yet we don't actually do anything with
it?

  Andrew