netdev - Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny unaligned packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56AA8428.2060706@familie-kirchhofer.de>
Date:	Thu, 28 Jan 2016 22:12:08 +0100
From:	Philipp Kirchhofer <philipp@...ilie-kirchhofer.de>
To:	Nicolas Schichan <nschichan@...ebox.fr>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Philipp Kirchhofer <philipp@...ilie-kirchhofer.de>
Subject: Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny
 unaligned packets.

Am 26.01.2016 um 16:12 schrieb Nicolas Schichan:
> The code in txq_put_data() would use txq->tx_curr_desc to index the
> tso_hdrs/tso_hdrs_dma buffers, for less than 8 bytes unaligned
> fragments, which is already moved to the next descriptor at the
> beginning of the function.
>
> If that fragment was the last of the the skb, the next skb would use
> that same space to place the ip headers, overwritting that small
> fragment data.
>
> Fixes: 91986fd3d335 (net: mv643xx_eth: Ensure proper data alignment in TSO TX path)
> Signed-off-by: Nicolas Schichan <nschichan@...ebox.fr>

Hello Nicolas,

thanks for catching this bug. Fix is good.

Reviewed-by: Philipp Kirchhofer <philipp@...ilie-kirchhofer.de>

Best wishes,
   Philipp