| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1454016364-30985-15-git-send-email-troy.kisky@boundarydevices.com> Date: Thu, 28 Jan 2016 14:25:38 -0700 From: Troy Kisky <troy.kisky@...ndarydevices.com> To: netdev@...r.kernel.org, davem@...emloft.net, B38611@...escale.com Cc: fabio.estevam@...escale.com, l.stach@...gutronix.de, andrew@...n.ch, tremyfr@...il.com, linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org, laci@...ndarydevices.com, shawnguo@...nel.org, Troy Kisky <troy.kisky@...ndarydevices.com> Subject: [PATCH net-next 14/40] net: fec: don't clear all rx queue bits when just one is being checked FEC_ENET_RXF is 3 separate bits, we only check one queue at a time. So, when the last queue is being checked, it is bad to remove the interrupt on the 1st queue. Also, since this is now done in the napi routine and not the interrupt, it is not needed. Signed-off-by: Troy Kisky <troy.kisky@...ndarydevices.com> --- drivers/net/ethernet/freescale/fec_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 04b1fb7..a7af1ac 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1330,8 +1330,6 @@ static int fec_rxq(struct net_device *ndev, struct fec_enet_private *fep, break; pkt_received++; - writel(FEC_ENET_RXF, fep->hwp + FEC_IEVENT); - /* Check for errors. */ status ^= BD_ENET_RX_LAST; if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH | BD_ENET_RX_NO | -- 2.5.0
Powered by blists - more mailing lists