netdev - Re: [PATCH net] macvlan: make operstate and carrier more accurate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160129.120727.2297321341636437499.davem@davemloft.net>
Date:	Fri, 29 Jan 2016 12:07:27 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	gospo@...ulusnetworks.com, kaber@...sh.net,
	nikolay@...ulusnetworks.com
Subject: Re: [PATCH net] macvlan: make operstate and carrier more accurate

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Wed, 27 Jan 2016 17:50:43 +0100

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> Currently when a macvlan is being initialized and the lower device is
> netif_carrier_ok(), the macvlan device doesn't run through
> rfc2863_policy() and is left with UNKNOWN operstate. Fix it by adding an
> unconditional linkwatch event for the new macvlan device. Similar fix is
> already used by the 8021q device (see register_vlan_dev()). Also fix the
> inconsistent state when the lower device has been down and its carrier
> was changed (when a device is down NETDEV_CHANGE doesn't get generated).
> The second issue can be seen f.e. when we have a macvlan on top of a 8021q
> device which has been down and its real device has been changing carrier
> states, after setting the 8021q device up, the macvlan device will have
> the same carrier state as it was before even though the 8021q can now
> have a different state.
 ...
> This behaviour seems to have been present since beginning of git history.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Applied, thanks Nikolay.