netdev - Re: wlcore: fix error handling in wlcore_event_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160129091520.9A0D76045B@smtp.codeaurora.org>
Date:	Fri, 29 Jan 2016 09:15:20 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Andrzej Hajda <a.hajda@...sung.com>
Cc:	Shahar Patury <shaharp@...com>,
	linux-wireless@...r.kernel.org (open list:TI WILINK WIRELESS DRIVERS),
	Andrzej Hajda <a.hajda@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	netdev@...r.kernel.org (open list:NETWORKING DRIVERS),
	linux-kernel@...r.kernel.org (open list)
Subject: Re: wlcore: fix error handling in wlcore_event_fw_logger


> wlcore_read/wlcore_write can return negative values so it should
> be assigned to signed variable.
> 
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2120705
> 
> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo