netdev - Re: [net PATCH] fib_trie: Fix shift by 32 in fib_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160129.194206.1773523483172152733.davem@davemloft.net>
Date:	Fri, 29 Jan 2016 19:42:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	aduyck@...antis.com
Cc:	netdev@...r.kernel.org, alexander.duyck@...il.com
Subject: Re: [net PATCH] fib_trie: Fix shift by 32 in fib_table_lookup

From: Alexander Duyck <aduyck@...antis.com>
Date: Thu, 28 Jan 2016 13:42:24 -0800

> The fib_table_lookup function had a shift by 32 that triggered a UBSAN
> warning.  This was due to the fact that I had placed the shift first and
> then followed it with the check for the suffix length to ignore the
> undefined behavior.  If we reorder this so that we verify the suffix is
> less than 32 before shifting the value we can avoid the issue.
> 
> Reported-by: Toralf Förster <toralf.foerster@....de>
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>

Applied.