lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56AD8163.4050309@huawei.com> Date: Sun, 31 Jan 2016 11:37:07 +0800 From: Weidong Wang <wangweidong1@...wei.com> To: Florian Westphal <fw@...len.de> CC: <pablo@...filter.org>, <kaber@...sh.net>, <kadlec@...ckhole.kfki.hu>, David Miller <davem@...emloft.net>, <netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] netfilter: nf_conntrack: remove the unneed check for *bucket On 2016/1/31 5:30, Florian Westphal wrote: > Weidong Wang <wangweidong1@...wei.com> wrote: >> In the 'for(...) {}', the *bucket alwasy < net->ct.htable_size, >> so remove the check >> @@ -1383,14 +1383,12 @@ get_next_corpse(struct net *net, int (*iter)(struct nf_conn *i, void *data), >> lockp = &nf_conntrack_locks[*bucket % CONNTRACK_LOCKS]; >> local_bh_disable(); >> spin_lock(lockp); >> - if (*bucket < net->ct.htable_size) { > > AFAIU net->ct.htable_size can shrink between for-test and aquiring > the bucket lockp, so this additional if-test is needed. > ok, Got it. So ignore this patch. Regards, Weidong > . >
Powered by blists - more mailing lists