lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56AFCD5E.7060400@gmail.com> Date: Mon, 01 Feb 2016 13:25:50 -0800 From: John Fastabend <john.fastabend@...il.com> To: Amir Vadai <amir@...ai.me> CC: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, John Fastabend <john.r.fastabend@...el.com>, Or Gerlitz <ogerlitz@...lanox.com>, Hadar Har-Zion <hadarh@...lanox.com>, Jiri Pirko <jiri@...lanox.com>, Jamal Hadi Salim <jhs@...atatu.com> Subject: Re: [RFC net-next 6/9] net/cls_flower: Introduce hardware offloading On 16-02-01 02:43 AM, Amir Vadai wrote: > On Mon, Feb 01, 2016 at 01:31:17AM -0800, John Fastabend wrote: >> On 16-02-01 12:34 AM, Amir Vadai wrote: >>> During initialization, tcf_exts_offload_init() is called to initialize >>> the list of actions description. later on, the classifier description >>> is prepared and sent to the switchdev using switchdev_port_flow_add(). >>> >>> When offloaded, fl_classify() is a NOP - already done in hardware. >>> >>> Signed-off-by: Amir Vadai <amir@...ai.me> >>> --- >> >> You need to account for where the classifier is being loaded >> by passing the handle as I did in my patch set. Otherwise you may >> be offloading on egress/ingress or even some qdisc multiple layers >> down in the hierarchy. > Right. Will fix it. also it seems you missed fl_delete() this will be called from cmds like 'tc filter delete ...' > >> >> .John >>
Powered by blists - more mailing lists