lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56AF5BF6.1030108@cogentembedded.com> Date: Mon, 1 Feb 2016 16:21:58 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>, netdev@...r.kernel.org Cc: tipc-discussion@...ts.sourceforge.net, jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com Subject: Re: [PATCH net-next v1 06/10] tipc: fix connection abort when receiving invalid cancel request Hello. On 2/1/2016 12:44 PM, Parthasarathy Bhuvaragan wrote: > Until now, the subscribers endianness for a subscription > create/cancel request is determined as: > swap = !(s->filter & (TIPC_SUB_PORTS | TIPC_SUB_SERVICE)) > The checks are performed only for port/service subscriptions. > > The swap calculation is incorrectly if the filter in the subscription Incorrect. > cancellation request is set to TIPC_SUB_CANCEL (its a malformed It's. > cancel request, as the corresponding subscription create filter > is missing). > Thus, the check if the request is for cancellation fails and the > request is treated as a subscription create request. The > subscription creation fails as the request is illegal, which > terminates this connection. > > In this commit we determine the endianness by including > TIPC_SUB_CANCEL, which will set swap correctly and the > request is processed as a cancel request. Cancellation, maybe, as it was worded above? > Acked-by: Ying Xue <ying.xue@...driver.com> > Reviewed-by: Jon Maloy <jon.maloy@...csson.com> > Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com> [...] MBR, Sergei
Powered by blists - more mailing lists