netdev - RE: [PATCH 1/1] ixgbe: get link speed as a slave nic unrelated with link up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87618083B2453E4A8714035B62D67992505210F8@FMSMSX105.amr.corp.intel.com>
Date:	Mon, 1 Feb 2016 15:55:18 +0000
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	"zyjzyj2000@...il.com" <zyjzyj2000@...il.com>,
	"Schmitt, Phillip J" <phillip.j.schmitt@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"Shteinbock, Boris (Wind River)" <boris.shteinbock@...driver.com>
Subject: RE: [PATCH 1/1] ixgbe: get link speed as a slave nic unrelated with
 link up

>-----Original Message-----
>From: zyjzyj2000@...il.com [mailto:zyjzyj2000@...il.com]
>Sent: Sunday, January 31, 2016 11:28 PM
>To: zyjzyj2000@...il.com; Tantilov, Emil S; Schmitt, Phillip J; Kirsher,
>Jeffrey T; netdev@...r.kernel.org; e1000-devel@...ts.sourceforge.net;
>Shteinbock, Boris (Wind River)
>Subject: [PATCH 1/1] ixgbe: get link speed as a slave nic unrelated with
>link up
>
>From: Zhu Yanjun <zyjzyj2000@...il.com>
>
>The commit 0e4d422f5f72 ("ixgbe: do not call check_link for ethtool
>in ixgbe_get_settings()") decreases the bonding failures. But the
>following time slice still results in a bonding failure.
>
>bonding                ixgbe
>  |                     |
>  |                    carrier_on
>  |                     |
>  |    <----------------|
> link_up                |
>  |                     |
>  |                    carrier_off
>  |                     |
> get_link_speed ------->|
>  |                     |

The driver does not set carrier_off unless the link is actually down.

Did you actually test this patch?

Thanks,
Emil