netdev - Re: [PATCH net] route: add rcu_read_lock when lookup route and update fnhe in __ip_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1454348968.7627.174.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 01 Feb 2016 09:49:28 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Xin Long <lucien.xin@...il.com>
Cc:	network dev <netdev@...r.kernel.org>, davem <davem@...emloft.net>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH net] route: add rcu_read_lock when lookup route and
 update fnhe in __ip_do_redirect

On Tue, 2016-02-02 at 01:16 +0800, Xin Long wrote:

> no, no stack dump was found.
> by reviewing code, I found it when I cooked another patch.
> 
> and the path that __ip_do_redirect() is called should be:
> 
> icmp_rcv |-> icmp_unreach  -\
>               |-> icmp_redirect -> icmp_socket_deliver -> ipprot->err_handler()
> [tcp_v4/6_err, sctp_v4/6_err, dccp_v4/6_err, udpv4/6_err ...]
> 
> -> ... -> __ip_do_redirect()
> 
> I checked the codes for many times, didn't find any rcu_lock on this path,
> unless we treat BH as rcu_lock.

Well I believe you missed something yes.

All RX paths run in rcu_read_lock()

ip_local_deliver_finish()
ipv6_rcv()
ip6_input_finish()