netdev - Re: [PATCH] net: drop write-only stack variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 21:50:21 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Herrmann <dh.herrmann@...il.com>, netdev@...r.kernel.org
Cc:	"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: drop write-only stack variable

On 02.02.2016 18:17, David Herrmann wrote:
> Remove a write-only stack variable from unix_attach_fds(). This is a
> left-over from the security fix in:
>
>      commit 712f4aad406bb1ed67f3f98d04c044191f0ff593
>      Author: willy tarreau <w@....eu>
>      Date:   Sun Jan 10 07:54:56 2016 +0100
>
>          unix: properly account for FDs passed over unix sockets
>
> Signed-off-by: David Herrmann <dh.herrmann@...il.com>

I don't think this specifically needs a Fixes tag. Seems more like a 
clean-up.

Anyway, I also noticed this during review and it can be removed safely.

Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Thanks,
Hannes