lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Feb 2016 11:39:28 +0100 From: Nicolas Dichtel <nicolas.dichtel@...nd.com> To: Daniel Borkmann <daniel@...earbox.net>, Stephen Hemminger <shemming@...cade.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "julien.floret@...nd.com" <julien.floret@...nd.com> Subject: Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis) Le 02/02/2016 10:08, Daniel Borkmann a écrit : > On 02/02/2016 05:51 AM, Stephen Hemminger wrote: >> On Tue, 19 Jan 2016 11:01:45 +0000 >> Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote: >> >>> diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c >>> index 42c8841869f5..219ffa582c1a 100644 >>> --- a/tc/tc_bpf.c >>> +++ b/tc/tc_bpf.c >>> @@ -49,6 +49,10 @@ >>> #include "tc_util.h" >>> #include "tc_bpf.h" >>> >>> +#ifndef AF_ALG >>> +#define AF_ALG 38 >>> +#endif >> >> Why is this here? AF_ALG is not used anywhere in this code. > > It is used, this patch is fine as-is. Yes, it's used and not defined with old toolchains: $ git grep AF_ALG tc/tc_bpf.c:#ifndef AF_ALG tc/tc_bpf.c:#define AF_ALG 38 tc/tc_bpf.c: .salg_family = AF_ALG, tc/tc_bpf.c: cfd = socket(AF_ALG, SOCK_SEQPACKET, 0); tc/tc_bpf.c: fprintf(stderr, "Cannot get AF_ALG socket: %s\n", Regards, Nicolas
Powered by blists - more mailing lists