| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1454499925-16359-6-git-send-email-jakub.kicinski@netronome.com> Date: Wed, 3 Feb 2016 11:45:11 +0000 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: davem@...emloft.net Cc: netdev@...r.kernel.org, Jakub Kicinski <jakub.kicinski@...ronome.com> Subject: [RFC (v3) 05/19] nfp: don't trust netif_running() in debug code Since change_mtu() can fail and leave us with netif_running() returning true even though all rings were freed - we should look at NFP_NET_CFG_CTRL_ENABLE flag to determine if device is really opened. Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com> --- drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c b/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c index 4c97c713121c..7af404d492cc 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c @@ -52,7 +52,7 @@ static int nfp_net_debugfs_rx_q_read(struct seq_file *file, void *data) if (!rx_ring->r_vec || !rx_ring->r_vec->nfp_net) goto out; nn = rx_ring->r_vec->nfp_net; - if (!netif_running(nn->netdev)) + if (!(nn->ctrl & NFP_NET_CFG_CTRL_ENABLE)) goto out; rxd_cnt = rx_ring->cnt; @@ -127,7 +127,7 @@ static int nfp_net_debugfs_tx_q_read(struct seq_file *file, void *data) if (!tx_ring->r_vec || !tx_ring->r_vec->nfp_net) goto out; nn = tx_ring->r_vec->nfp_net; - if (!netif_running(nn->netdev)) + if (!(nn->ctrl & NFP_NET_CFG_CTRL_ENABLE)) goto out; txd_cnt = tx_ring->cnt; -- 1.9.1
Powered by blists - more mailing lists