netdev - Re: [net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201602031914.c9iNaNug%fengguang.wu@intel.com>
Date:	Wed, 3 Feb 2016 19:44:58 +0800
From:	kbuild test robot <lkp@...el.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	kbuild-all@...org, amir@...ai.me, ogerlitz@...lanox.com,
	jiri@...nulli.us, jhs@...atatu.com, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [net-next PATCH 1/7] net: rework ndo tc op to consume additional
 qdisc handle parameter

Hi John,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/John-Fastabend/tc-offload-for-cls_u32-on-ixgbe/20160203-173342
config: x86_64-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/amd/xgbe/xgbe-drv.c:1715:19: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
     .ndo_setup_tc  = xgbe_setup_tc,
                      ^
   drivers/net/ethernet/amd/xgbe/xgbe-drv.c:1715:19: note: (near initialization for 'xgbe_netdev_ops.ndo_setup_tc')
--
>> drivers/net/ethernet/intel/i40e/i40e_fcoe.c:1460:19: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
     .ndo_setup_tc  = i40e_setup_tc,
                      ^
   drivers/net/ethernet/intel/i40e/i40e_fcoe.c:1460:19: note: (near initialization for 'i40e_fcoe_netdev_ops.ndo_setup_tc')

vim +1715 drivers/net/ethernet/amd/xgbe/xgbe-drv.c

c5aa9e3b Lendacky, Thomas 2014-06-05  1699  static const struct net_device_ops xgbe_netdev_ops = {
c5aa9e3b Lendacky, Thomas 2014-06-05  1700  	.ndo_open		= xgbe_open,
c5aa9e3b Lendacky, Thomas 2014-06-05  1701  	.ndo_stop		= xgbe_close,
c5aa9e3b Lendacky, Thomas 2014-06-05  1702  	.ndo_start_xmit		= xgbe_xmit,
c5aa9e3b Lendacky, Thomas 2014-06-05  1703  	.ndo_set_rx_mode	= xgbe_set_rx_mode,
c5aa9e3b Lendacky, Thomas 2014-06-05  1704  	.ndo_set_mac_address	= xgbe_set_mac_address,
c5aa9e3b Lendacky, Thomas 2014-06-05  1705  	.ndo_validate_addr	= eth_validate_addr,
23e4eef7 Lendacky, Thomas 2014-07-29  1706  	.ndo_do_ioctl		= xgbe_ioctl,
c5aa9e3b Lendacky, Thomas 2014-06-05  1707  	.ndo_change_mtu		= xgbe_change_mtu,
a8373f1a Lendacky, Thomas 2015-04-09  1708  	.ndo_tx_timeout		= xgbe_tx_timeout,
c5aa9e3b Lendacky, Thomas 2014-06-05  1709  	.ndo_get_stats64	= xgbe_get_stats64,
801c62d9 Lendacky, Thomas 2014-06-24  1710  	.ndo_vlan_rx_add_vid	= xgbe_vlan_rx_add_vid,
801c62d9 Lendacky, Thomas 2014-06-24  1711  	.ndo_vlan_rx_kill_vid	= xgbe_vlan_rx_kill_vid,
c5aa9e3b Lendacky, Thomas 2014-06-05  1712  #ifdef CONFIG_NET_POLL_CONTROLLER
c5aa9e3b Lendacky, Thomas 2014-06-05  1713  	.ndo_poll_controller	= xgbe_poll_controller,
c5aa9e3b Lendacky, Thomas 2014-06-05  1714  #endif
fca2d994 Lendacky, Thomas 2014-07-29 @1715  	.ndo_setup_tc		= xgbe_setup_tc,
c5aa9e3b Lendacky, Thomas 2014-06-05  1716  	.ndo_set_features	= xgbe_set_features,
c5aa9e3b Lendacky, Thomas 2014-06-05  1717  };
c5aa9e3b Lendacky, Thomas 2014-06-05  1718  
c5aa9e3b Lendacky, Thomas 2014-06-05  1719  struct net_device_ops *xgbe_get_netdev_ops(void)
c5aa9e3b Lendacky, Thomas 2014-06-05  1720  {
c5aa9e3b Lendacky, Thomas 2014-06-05  1721  	return (struct net_device_ops *)&xgbe_netdev_ops;
c5aa9e3b Lendacky, Thomas 2014-06-05  1722  }
c5aa9e3b Lendacky, Thomas 2014-06-05  1723  

:::::: The code at line 1715 was first introduced by commit
:::::: fca2d99428473884e67ef8ea1586e58151ed6ac3 amd-xgbe: Add traffic class support

:::::: TO: Lendacky, Thomas <Thomas.Lendacky@....com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (53132 bytes)