lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 3 Feb 2016 12:19:11 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Linus Torvalds' <>,
	Hannes Frederic Sowa <>
CC:	David Herrmann <>, Willy Tarreau <>,
	"David S. Miller" <>,
	netdev <>,
	linux-kernel <>,
	Eric Dumazet <>,
	???? ????????? <>,
	Tetsuo Handa <>,
	Simon McVittie <>
Subject: RE: [PATCH v2] unix: properly account for FDs passed over unix

From: Linus Torvalds
> Sent: 02 February 2016 20:45
> On Tue, Feb 2, 2016 at 12:32 PM, Hannes Frederic Sowa
> <> wrote:
> >
> > Unfortunately we never transfer a scm_cookie via the skbs but merely use it
> > to initialize unix_skb_parms structure in skb->cb and destroy it afterwards.
> Ok, I obviously didn't check very closely.
> > But "struct pid *" in unix_skb_parms should be enough to get us to
> > corresponding "struct cred *" so we can decrement the correct counter during
> > skb destruction.
> Umm. I think the "struct cred" may change in between, can't it?
> So I don't think you can later look up the cred based on the pid.
> Could we add the cred pointer (or just the user pointer) to the unix_skb_parms?
> Or maybe just add it to the "struct scm_fp_list"?

Is that going to work if the sending process exits before the message is read?
You need a reference count against the structure than contains the count.
I think this is 'struct user' not 'struct cred'


Powered by blists - more mailing lists