lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Feb 2016 11:31:49 +0900 From: ByeoungWook Kim <quddnr145@...il.com> To: Julian Calaby <julian.calaby@...il.com> Cc: Larry Finger <Larry.Finger@...inger.net>, Kalle Valo <kvalo@...eaurora.org>, Chaoming Li <chaoming_li@...lsil.com.cn>, linux-wireless <linux-wireless@...r.kernel.org>, netdev <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c Hi Julian, I sent to modify the patch again. Thanks for your assists! Regards, Byeoungwook 2016-02-03 11:06 GMT+09:00 Julian Calaby <julian.calaby@...il.com>: > Hi Byeoungwook, > > On Wed, Feb 3, 2016 at 1:01 PM, Byeoungwook Kim <quddnr145@...il.com> wrote: >> rtl_*_delay() functions were reused same codes about addr variable. >> So i have converted to rtl_addr_delay() from code about addr variable. >> >> Signed-off-by: Byeoungwook Kim <quddnr145@...il.com> >> Reviewed-by: Julian Calaby <julian.calaby@...il.com> > > Just a note for the future, you have to explicitly be given a > reviewed-by, you can't just assume that someone who has made comments > on a patch has reviewed it. > > In this case, I have reviewed it, so formally: > > Reviewed-by: Julian Calaby <julian.calaby@...il.com> > > Thanks, > > Julian Calaby > > >> --- >> drivers/net/wireless/realtek/rtlwifi/core.c | 28 ++++------------------------ >> 1 file changed, 4 insertions(+), 24 deletions(-) >> >> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c >> index 05f432c..c1193d1 100644 >> --- a/drivers/net/wireless/realtek/rtlwifi/core.c >> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c >> @@ -63,18 +63,8 @@ EXPORT_SYMBOL(rtl_addr_delay); >> void rtl_rfreg_delay(struct ieee80211_hw *hw, enum radio_path rfpath, u32 addr, >> u32 mask, u32 data) >> { >> - if (addr == 0xfe) { >> - mdelay(50); >> - } else if (addr == 0xfd) { >> - mdelay(5); >> - } else if (addr == 0xfc) { >> - mdelay(1); >> - } else if (addr == 0xfb) { >> - udelay(50); >> - } else if (addr == 0xfa) { >> - udelay(5); >> - } else if (addr == 0xf9) { >> - udelay(1); >> + if (addr >= 0xf9 && addr <= 0xfe) { >> + rtl_addr_delay(addr); >> } else { >> rtl_set_rfreg(hw, rfpath, addr, mask, data); >> udelay(1); >> @@ -84,18 +74,8 @@ EXPORT_SYMBOL(rtl_rfreg_delay); >> >> void rtl_bb_delay(struct ieee80211_hw *hw, u32 addr, u32 data) >> { >> - if (addr == 0xfe) { >> - mdelay(50); >> - } else if (addr == 0xfd) { >> - mdelay(5); >> - } else if (addr == 0xfc) { >> - mdelay(1); >> - } else if (addr == 0xfb) { >> - udelay(50); >> - } else if (addr == 0xfa) { >> - udelay(5); >> - } else if (addr == 0xf9) { >> - udelay(1); >> + if (addr >= 0xf9 && addr <= 0xfe) { >> + rtl_addr_delay(addr); >> } else { >> rtl_set_bbreg(hw, addr, MASKDWORD, data); >> udelay(1); >> -- >> 2.5.0 >> > > > > -- > Julian Calaby > > Email: julian.calaby@...il.com > Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists