netdev - Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56B25215.10204@cumulusnetworks.com>
Date:	Wed, 3 Feb 2016 20:16:37 +0100
From:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:	Jay Vosburgh <jay.vosburgh@...onical.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Veaceslav Falico <vfalico@...il.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>
Subject: Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes
 immediately

On 02/03/2016 08:05 PM, Jay Vosburgh wrote:
> Nikolay Aleksandrov <razor@...ckwall.org> wrote:
> 
>> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
>>
>> Currently the bonding allows to set ad_actor_system and prio while the
>> bond device is down, but these are actually applied only if there aren't
>> any slaves yet (applied to bond device when first slave shows up, and to
>> slaves at 3ad bind time). After this patch changes are applied immediately
>> and the new values can be used/seen after the bond's upped so it's not
>> necessary anymore to release all and enslave again to see the changes.
>>
>> CC: Jay Vosburgh <j.vosburgh@...il.com>
>> CC: Veaceslav Falico <vfalico@...il.com>
>> CC: Andy Gospodarek <gospo@...ulusnetworks.com>
>> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> 	Looks good to me.
> 
> Signed-off-by: Jay Vosburgh <jay.vosburgh@...onical.com>
> 
> 	-J
> 

Thanks Jay. Do you think it makes sense to allow setting these while the
bond is up ? I don't see any serious problems.