lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 03 Feb 2016 21:40:51 +0100 From: Arnd Bergmann <arnd@...db.de> To: Grygorii Strashko <grygorii.strashko@...com> Cc: "Franklin S Cooper Jr." <fcooper@...com>, m-karicheri2@...com, netdev@...r.kernel.org, w-kwok2@...com, davem@...emloft.net, Santosh Shilimkar <ssantosh@...nel.org> Subject: Re: Keystone 2 boards boot failure On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: > On 02/03/2016 06:20 PM, Arnd Bergmann wrote: > > On Wednesday 03 February 2016 16:21:05 Grygorii Strashko wrote: > >> On 02/03/2016 04:11 PM, Franklin S Cooper Jr. wrote: > >>> On 02/02/2016 07:19 PM, Franklin S Cooper Jr. wrote: > > > > This looks wrong: I was getting the build warnings originally > > because of 64-bit dma_addr_t, and that should be the only way that > > this driver can operate, because in some configurations on keystone > > there is no memory below 4GB, and there is no dma-ranges property > > in the DT that shifts around the start of the DMA addresses. > > see keystone.dtsi: > soc { > #address-cells = <1>; > #size-cells = <1>; > compatible = "ti,keystone","simple-bus"; > interrupt-parent = <&gic>; > ranges = <0x0 0x0 0x0 0xc0000000>; > dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>; > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ You are right, I totally missed it when I looked again. I thought it was correct but then couldn't find it in the dts. > config: > > CONFIG_ARCH_PHYS_ADDR_T_64BIT=y > CONFIG_PHYS_ADDR_T_64BIT=y > > and > > #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT <--- should not be defined for KS2 > typedef u64 dma_addr_t; > #else > typedef u32 dma_addr_t; > #endif > > Above is valid configuration for Keystone 2 with LPAE=y Ok, but what do you mean with "should not be defined"? It clearly is defined in any multiplatform configuration that enables another platform needing 64-bit dma_addr_t. Arnd
Powered by blists - more mailing lists