lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Feb 2016 14:21:46 +0900 From: Byeoungwook Kim <quddnr145@...il.com> To: Larry.Finger@...inger.net Cc: kvalo@...eaurora.org, chaoming_li@...lsil.com.cn, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, lkp@...el.com, julian.calaby@...il.com Subject: [PATCH v3] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Reviewed-by: Julian Calaby <julian.calaby@...il.com> Signed-off-by: Byeoungwook Kim <quddnr145@...il.com> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com> --- V3 remove unneeded semicolon. V2 split in separate patchs. drivers/net/wireless/realtek/rtlwifi/core.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c index 4ae421e..63cda78 100644 --- a/drivers/net/wireless/realtek/rtlwifi/core.c +++ b/drivers/net/wireless/realtek/rtlwifi/core.c @@ -37,18 +37,26 @@ void rtl_addr_delay(u32 addr) { - if (addr == 0xfe) + switch (addr) { + case 0xfe: mdelay(50); - else if (addr == 0xfd) + break; + case 0xfd: mdelay(5); - else if (addr == 0xfc) + break; + case 0xfc: mdelay(1); - else if (addr == 0xfb) + break; + case 0xfb: udelay(50); - else if (addr == 0xfa) + break; + case 0xfa: udelay(5); - else if (addr == 0xf9) + break; + case 0xf9: udelay(1); + break; + } } EXPORT_SYMBOL(rtl_addr_delay); -- 2.5.0
Powered by blists - more mailing lists