netdev - Re: [net] bonding: use return instead of goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Feb 2016 14:26:22 -0500
From:	Jarod Wilson <jarod@...hat.com>
To:	Zhang Shengju <zhangshengju@...s.chinamobile.com>
Cc:	j.vosburgh@...il.com, netdev@...r.kernel.org
Subject: Re: [net] bonding: use return instead of goto

On Wed, Feb 03, 2016 at 06:15:22AM +0000, Zhang Shengju wrote:
> Replace 'goto' with 'return' to remove unnecessary check at label:
> err_undo_flags.

I think you're going to have to explain how you came to the conclusion
that the check isn't necessary.

-- 
Jarod Wilson
jarod@...hat.com