netdev - Re: header conflict introduced by change to netfilter_ipv4/ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA4P2avVr+m=ittQUyBou9kT2nbK0-Jeo+3coAFyQXTT_A@mail.gmail.com>
Date:	Thu, 4 Feb 2016 02:13:09 -0500
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Mikko Rapeli <mikko.rapeli@....fi>
Cc:	Stephen Hemminger <shemming@...cade.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>
Subject: Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h

On Thu, Jan 7, 2016 at 2:15 PM, Mikko Rapeli <mikko.rapeli@....fi> wrote:
> On Thu, Jan 07, 2016 at 10:30:40AM -0800, Stephen Hemminger wrote:
>> On Thu, 7 Jan 2016 07:29:50 +0000
>> Mikko Rapeli <mikko.rapeli@....fi> wrote:
>>
>> > On Wed, Jan 06, 2016 at 09:20:07AM -0800, Stephen Hemminger wrote:
>> > > This commit breaks compilation of iproute2 with net-next.
>> >
>> > Ok, linux/if.h and libc net/if.h have overlapping defines, and this is not
>> > the only one. I saw lots of them in the core dump headers.
>> >
>> > How should we handle them? Another ifndef for IFNAMSIZ into kernel uapi
>> > headers?
>> >
>> > -Mikko
>>
>> Probably need to do the same thing that was done previously for these
>> kind of conflicts.  This makes make linux/if.h change to adapt to net/if.h
>> being included before it.
>
> Ok, got it. And found include/uapi/linux/libc-compat.h. Did not know about it
> and was looking for solutions to these problems.
>
> But now I feel like writing a test script for mixing of kernel uapi
> and libc headers to find out how many other collitions are still there.
> Not good for the pile of over 70 patches in my branch
> https://github.com/torvalds/linux/compare/master...mcfrisk:headers_test_v05
>
>> Or revert your patch.
>
> I'm fine with this too.

This is causing a number of build failures in Fedora rawhide now.  Did
anyone submit a revert or patch to fix this issue?

josh