netdev - Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2016 16:42:40 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	"davem@...emloft.net" <davem@...emloft.net>
CC:	"andrew@...n.ch" <andrew@...n.ch>,
	"Nelson, Shannon" <shannon.nelson@...el.com>,
	"aduyck@...antis.com" <aduyck@...antis.com>,
	"thomas.petazzoni@...e-electrons.com" 
	<thomas.petazzoni@...e-electrons.com>,
	"mcarlson@...adcom.com" <mcarlson@...adcom.com>,
	"yuvalmin@...adcom.com" <yuvalmin@...adcom.com>,
	"amirv@...lanox.com" <amirv@...lanox.com>,
	"Williams, Mitch A" <mitch.a.williams@...el.com>,
	"_govind@....com" <_govind@....com>,
	"Lendacky@...r.kernel.org" <Lendacky@...r.kernel.org>,
	"Tantilov, Emil S" <emil.s.tantilov@...el.com>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"mirq-linux@...e.qmqm.pl" <mirq-linux@...e.qmqm.pl>,
	"hariprasad@...lsio.com" <hariprasad@...lsio.com>,
	"kalesh.purayil@...lex.com" <kalesh.purayil@...lex.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"mchan@...adcom.com" <mchan@...adcom.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"sgoutham@...ium.com" <sgoutham@...ium.com>,
	"Thomas.Lendacky@....com" <Thomas.Lendacky@....com>,
	"achiad@...lanox.com" <achiad@...lanox.com>
Subject: Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH
 commands

On Thu, 2016-02-04 at 19:30 -0500, David Miller wrote:
> From: "Keller, Jacob E" <jacob.e.keller@...el.com>
> Date: Thu, 4 Feb 2016 23:09:56 +0000
> 
> > So you're suggesting instead, to error when the second operation
> > (change number of queues) would fail the current settings?
> 
> Yes.
> 
> This is absolutely required.

I will investigate this route. I think there needs to some way for the
{GS}RXFH to pass enough information in a way the driver can clearly see
as "reset to default", but otherwise I think this is pretty straight
forward to implement.

Thanks,
Jake