netdev - Re: [PATCH net v4] r8169: Add bios support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160206.023932.2140900219779859048.davem@davemloft.net>
Date:	Sat, 06 Feb 2016 02:39:32 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	asd@...ian1000.go.ro
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net v4] r8169: Add bios support.

From: Corcodel Marian <asd@...ian1000.go.ro>
Date: Sat,  6 Feb 2016 08:31:26 +0200

> @@ -8262,8 +8262,9 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	rtl_hw_reset(tp);
>  
>  	rtl_ack_events(tp, 0xffff);
> -
> +#ifndef CONFIG_BIOS_SUPPORT
>  	pci_set_master(pdev);
> +#endif

I already made it clear to you that it is perfectly fine to unconditionally
call pci_set_master() from the driver in any circumstance.

Look across all of the drivers under drivers/net/ that invoke this function,
it's meant to be used this way and it's fine.

There is absolutely no reason to conditionalize it.

Thanks.