netdev - Re: [PATCH v2] ipv6: addrconf: Fix recursive spin lock call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160206.030944.1340132870709460187.davem@davemloft.net>
Date:	Sat, 06 Feb 2016 03:09:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	subashab@...eaurora.org
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, ek@...gle.com,
	hannes@...essinduktion.org
Subject: Re: [PATCH v2] ipv6: addrconf: Fix recursive spin lock call

From: subashab@...eaurora.org
Date: Tue, 2 Feb 2016 02:11:10 -0000

> A rcu stall with the following backtrace was seen on a system with
> forwarding, optimistic_dad and use_optimistic set. To reproduce,
> set these flags and allow ipv6 autoconf.
> 
> This occurs because the device write_lock is acquired while already
> holding the read_lock. Back trace below -
 ...
> v2: do addrconf_dad_kick inside read lock and then acquire write
> lock for ipv6_ifa_notify as suggested by Eric
> 
> Fixes: 7fd2561e4ebdd ("net: ipv6: Add a sysctl to make optimistic
> addresses useful candidates")
> 
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Erik Kline <ek@...gle.com>
> Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>

Applied and queued up for -stable, thanks.