netdev - Re: [PATCH net-next 0/2] tcp: fastopen: accept data/FIN present in SYNACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1454784731.7627.329.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 06 Feb 2016 10:52:11 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	edumazet@...gle.com, netdev@...r.kernel.org, sara@...odun.com,
	ycheng@...gle.com
Subject: Re: [PATCH net-next 0/2] tcp: fastopen: accept data/FIN present in
 SYNACK

On Sat, 2016-02-06 at 03:13 -0500, David Miller wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Mon,  1 Feb 2016 21:03:06 -0800
> 
> > Implements RFC 7413 (TCP Fast Open) 4.2.2, accepting payload and/or FIN
> > in SYNACK messages, and prepare removal of SYN flag in tcp_recvmsg()
> 
> Series applied, thanks Eric.

It seems I missed to call tcp_fin() if a FIN flag was present.

(But then we had this issue before my patches, Yuchung, for a SYN packet
+ FIN  ?)

I will send a followup.

Thanks David.