netdev - Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160206194045.GA2282@nanopsycho.orion>
Date:	Sat, 6 Feb 2016 20:40:45 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Jesper Dangaard Brouer <brouer@...hat.com>,
	netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
	eladr@...lanox.com, yotamg@...lanox.com, ogerlitz@...lanox.com,
	yishaih@...lanox.com, dledford@...hat.com, sean.hefty@...el.com,
	hal.rosenstock@...il.com, eugenia@...lanox.com,
	roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
	hadarh@...lanox.com, jhs@...atatu.com, john.fastabend@...il.com,
	jeffrey.t.kirsher@...el.com, jbenc@...hat.com
Subject: Re: [patch net-next RFC 0/6] Introduce devlink interface and first
 drivers to use it

Fri, Feb 05, 2016 at 06:38:42PM CET, alexei.starovoitov@...il.com wrote:
>On Fri, Feb 05, 2016 at 11:01:22AM +0100, Hannes Frederic Sowa wrote:
>> 
>> Okay. I see it more as changing mode of operation of hardware and thus has
>> not really anything to do with networking. If you say you change ethernet to
>> infiniband it has something to do with networking, sure. But I am fine with
>> this, I just thought the code size could be reduced by adding this to sysfs
>> quite a lot. I don't have a strong opinion on this.
>
>there is already a way to change eth/ib via
>echo 'eth' > /sys/bus/pci/drivers/mlx4_core/0000:02:00.0/mlx4_port1
>
>sounds like this is another way to achieve the same?

It is. However the current way is driver-specific, not correct.
For mlx5, we need the same, it cannot be done in this way. Do devlink is
the correct way to go.


>Why not hide echo/cat in iproute2 instead of adding parallel netlink api?
>Or this is for switches instead of nics?
>Then why it's not adding to switchdev?

Note this is not specific to switch ASICs. This is for all network devices.