netdev - Re: [net-next PATCH 10/10] net: Allow tunnels to use inner checksum offloads with outer checksums needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S37xA7c_BA4h-AzeFF+Q2XdKnJG5veuoiNYrLzScRe6Y=w@mail.gmail.com>
Date:	Sat, 6 Feb 2016 13:00:07 -0800
From:	Tom Herbert <tom@...bertland.com>
To:	Alexander Duyck <aduyck@...antis.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Alexander Duyck <alexander.duyck@...il.com>,
	Edward Cree <ecree@...arflare.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [net-next PATCH 10/10] net: Allow tunnels to use inner checksum
 offloads with outer checksums needed

On Fri, Feb 5, 2016 at 3:28 PM, Alexander Duyck <aduyck@...antis.com> wrote:
> This patch enables us to use inner checksum offloads if provided by
> hardware with outer checksums computed by software.
>
> It basically reduces encap_hdr_csum to an advisory flag for now, but based
> on the fact that SCTP may be getting segmentation support before long I
> thought we may want to keep it as it is possible we may need to support
> CRC32c and 1's compliment checksum in the same packet at some point in the
> future.
>
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>

Acked-by: Tom Herbert <tom@...bertland.com>

> ---
>  net/core/skbuff.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 88262c82b96a..b0cce744e2a0 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -3004,8 +3004,7 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb,
>         if (unlikely(!proto))
>                 return ERR_PTR(-EINVAL);
>
> -       csum = !head_skb->encap_hdr_csum &&
> -           !!can_checksum_protocol(features, proto);
> +       csum = !!can_checksum_protocol(features, proto);
>
>         headroom = skb_headroom(head_skb);
>         pos = skb_headlen(head_skb);
>