netdev - Re: [PATCH net-next] tcp: fastopen: call tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160206.165015.2150156850444799755.davem@davemloft.net>
Date:	Sat, 06 Feb 2016 16:50:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	edumazet@...gle.com, netdev@...r.kernel.org, sara@...odun.com,
	ycheng@...gle.com, ncardwell@...gle.com
Subject: Re: [PATCH net-next] tcp: fastopen: call tcp_fin() if FIN present
 in SYNACK

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 06 Feb 2016 11:16:28 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When we acknowledge a FIN, it is not enough to ack the sequence number
> and queue the skb into receive queue. We also have to call tcp_fin()
> to properly update socket state and send proper poll() notifications.
> 
> It seems we also had the problem if we received a SYN packet with the
> FIN flag set, but it does not seem an urgent issue, as no known
> implementation can do that.
> 
> Fixes: 61d2bcae99f6 ("tcp: fastopen: accept data/FIN present in SYNACK message")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.