netdev - Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pow83fp5.fsf@belgarion.home>
Date:	Sun, 07 Feb 2016 12:47:18 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

Sergei Shtylyov <sergei.shtylyov@...entembedded.com> writes:

>> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse
>
>    Fixes: tag here?
Heuh no. It doesn't fix this commit, it uses a feature brought by this commit.

>> +	if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE)
>>   		dev_warn(db->dev, "WARNING: no IRQ resource flags set.\n");
>>
>>   	irqflags |= IRQF_SHARED;
>
>    Why not just initialize to IRQF_SHARED?
>    But actually you don't need this variable anymore.
Yeah, makes sense.

Cheers.

-- 
Robert