netdev - Re: [PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160207.143117.2074335859138369633.davem@davemloft.net>
Date:	Sun, 07 Feb 2016 14:31:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, mst@...hat.com, roopa@...ulusnetworks.com,
	nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next v5 0/2] virtio_net: add ethtool get/set
 settings support

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Wed,  3 Feb 2016 04:04:35 +0100

> Patch 1 adds ethtool speed/duplex validation functions which check if the
> value is defined. Patch 2 adds support for ethtool (get|set)_settings and
> uses the validation functions to check the user-supplied values.
> 
> v2: split in 2 patches to allow everyone to make use of the validation
> functions and allow virtio_net devices to be half duplex
> v3: added a check to return error if the user tries to change anything else
> besides duplex/speed as per Michael's comment
> v4: Set port type to PORT_OTHER
> v5: clear diff1.port (ignore port) when checking for changes since we set
> it now and ethtool uses it in the set request
> 
> Sorry about the pointless iterations, should've all covered now.

Series applied, thanks Nik.