netdev - Re: [PATCH iproute2] bridge: support for static fdb entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 7 Feb 2016 11:41:57 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, wkok@...ulusnetworks.com,
	scotte@...ulusnetworks.com, nikolay@...ulusnetworks.com,
	makita.toshiaki@....ntt.co.jp
Subject: Re: [PATCH iproute2] bridge: support for static fdb entries

On Wed, 27 Jan 2016 09:09:37 -0800
Roopa Prabhu <roopa@...ulusnetworks.com> wrote:

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> There is no intuitive option to add static fdb entries today.
> 'temp' seems to have a side effect of adding
> 'static' fdb entries. But the name and intent
> of 'temp' does not say anything about it being static.
> 
> example:
> bridge fdb add operates as follows:
> 
> $bridge fdb add 00:01:02:03:04:05 dev eth0 master
> $bridge fdb add 00:01:02:03:04:06 dev eth0 master temp
> $bridge fdb add 00:01:02:03:04:07 dev eth0 master local
> 
> $bridge fdb show
> 00:01:02:03:04:05 dev eth0 permanent
> 00:01:02:03:04:06 dev eth0 static
> 00:01:02:03:04:07 dev eth0 permanent
> 00:01:02:03:04:08 dev eth0 <<== dynamic, ageable learned mac
> 
> This patch adds a new bridge fdb type 'static' which
> makes sure NUD_NOARP and NUD_REACHABLE is set for static
> entries. This effectively is nothing but what 'temp'
> does today. But the name 'temp' is misleading.
> 
> After the patch:
> $bridge fdb add 00:01:02:03:04:06 dev eth0 master static
> 
> $bridge fdb show
> 00:01:02:03:04:06 dev eth0 static
> 
> 'temp' could ideally be a dynamic mac that can age (ie just
> NUD_REACHABLE). But, 'temp' sets 'NUD_NOARP' and 'NUD_REACHABLE'.
> Too late to change 'temp' now. But, we are thinking of introduing a
> 'dynamic' keyword after this patch that only sets NUD_REACHABLE.
> 
> Signed-off-by: Wilson Kok <wkok@...ulusnetworks.com>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
> Will submit another patch to document bridge fdb options
> once we agree on the behaviour and this patch is accepted.
> 
>  bridge/fdb.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Appled.
Please update man page