netdev - Re: [PATCH net] unix: correctly track in-flight fds in sending process user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160208.103227.1734389685709628459.davem@davemloft.net>
Date:	Mon, 08 Feb 2016 10:32:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, dh.herrmann@...il.com, w@....eu,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH net] unix: correctly track in-flight fds in sending
 process user_struct

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Wed,  3 Feb 2016 02:11:03 +0100

> The commit referenced in the Fixes tag incorrectly accounted the number
> of in-flight fds over a unix domain socket to the original opener
> of the file-descriptor. This allows another process to arbitrary
> deplete the original file-openers resource limit for the maximum of
> open files. Instead the sending processes and its struct cred should
> be credited.
> 
> To do so, we add a reference counted struct user_struct pointer to the
> scm_fp_list and use it to account for the number of inflight unix fds.
> 
> Fixes: 712f4aad406bb1 ("unix: properly account for FDs passed over unix sockets")
> Reported-by: David Herrmann <dh.herrmann@...il.com>
> Cc: David Herrmann <dh.herrmann@...il.com>
> Cc: Willy Tarreau <w@....eu>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied, thanks Hannes.