netdev - Re: [PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Feb 2016 04:24:18 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jacob Keller <jacob.e.keller@...el.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org, mooray3@...pl,
	davem@...emloft.net, Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't
 conflict with GS{RXFH}

Hi Jacob,

[auto build test ERROR on net/master]
[also build test ERROR on v4.5-rc3 next-20160208]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Jacob-Keller/ethtool-correctly-ensure-GS-CHANNELS-doesn-t-conflict-with-GS-RXFH/20160209-041131
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   net/core/ethtool.c: In function 'ethtool_set_channels':
>> net/core/ethtool.c:1292:6: error: implicit declaration of function 'ethtool_get_max_rxfh_channel' [-Werror=implicit-function-declaration]
         ethtool_get_max_rxfh_channel(dev, &max_rx) &&
         ^
>> net/core/ethtool.c:1295:6: error: expected ')' before 'return'
         return -EINVAL;
         ^
>> net/core/ethtool.c:1298:1: error: expected expression before '}' token
    }
    ^
   net/core/ethtool.c:1281:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret;
         ^
   net/core/ethtool.c:1298:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^
   cc1: some warnings being treated as errors

vim +/ethtool_get_max_rxfh_channel +1292 net/core/ethtool.c

  1286		if (copy_from_user(&channels, useraddr, sizeof(channels)))
  1287			return -EFAULT;
  1288	
  1289		/* ensure the new Rx count fits within the configured Rx flow
  1290		 * indirection table settings */
  1291		if (netif_is_rxfh_configured(dev) &&
> 1292		    ethtool_get_max_rxfh_channel(dev, &max_rx) &&
  1293		    ((channels.rx_count > max_rx) ||
  1294		     (channels.combined_count > max_rx))
> 1295		    return -EINVAL;
  1296	
  1297		return dev->ethtool_ops->set_channels(dev, &channels);
> 1298	}
  1299	
  1300	static int ethtool_get_pauseparam(struct net_device *dev, void __user *useraddr)
  1301	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44070 bytes)