netdev - Re: [PATCH net v2] tg3: Fix for tg3 transmit queue 0 timed out when too many gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Feb 2016 04:40:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	siva.kallam@...adcom.com
Cc:	netdev@...r.kernel.org, mchan@...adcom.com, prashant@...adcom.com
Subject: Re: [PATCH net v2] tg3: Fix for tg3 transmit queue 0 timed out
 when too many gso_segs

From: skallam <siva.kallam@...adcom.com>
Date: Wed,  3 Feb 2016 14:09:38 +0530

> From: Siva Reddy Kallam <siva.kallam@...adcom.com>
> 
> tg3_tso_bug() can hit a condition where the entire tx ring is not big
> enough to segment the GSO packet. For example, if MSS is very small,
> gso_segs can exceed the tx ring size. When we hit the condition, it
> will cause tx timeout.
> 
> tg3_tso_bug() is called to handle TSO and DMA hardware bugs.
> For TSO bugs, if tg3_tso_bug() cannot succeed, we have to drop the packet.
> For DMA bugs, we can still fall back to linearize the SKB and let the
> hardware transmit the TSO packet.
> 
> This patch adds a function tg3_tso_bug_gso_check() to check if there
> are enough tx descriptors for GSO before calling tg3_tso_bug().
> The caller will then handle the error appropriately - drop or
> lineraize the SKB.
> 
> v2: Corrected patch description to avoid confusion.
> 
> Signed-off-by: Siva Reddy Kallam <siva.kallam@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Acked-by: Prashant Sreedharan <prashant@...adcom.com>

Applied and queued up for -stable.

Thanks.