netdev - Re: [net PATCH v2] flow_dissector: Fix unaligned access in __skb_flow_dissector when used by eth_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160209.070843.147439680193879267.davem@davemloft.net>
Date:	Tue, 09 Feb 2016 07:08:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	aduyck@...antis.com
Cc:	netdev@...r.kernel.org, alexander.duyck@...il.com,
	tom@...bertland.com
Subject: Re: [net PATCH v2] flow_dissector: Fix unaligned access in
 __skb_flow_dissector when used by eth_get_headlen

From: Alexander Duyck <aduyck@...antis.com>
Date: Tue, 09 Feb 2016 02:49:54 -0800

> This patch fixes an issue with unaligned accesses when using
> eth_get_headlen on a page that was DMA aligned instead of being IP aligned.
> The fact is when trying to check the length we don't need to be looking at
> the flow label so we can reorder the checks to first check if we are
> supposed to gather the flow label and then make the call to actually get
> it.
> 
> v2:  Updated path so that either STOP_AT_FLOW_LABEL or KEY_FLOW_LABEL can
>      cause us to check for the flow label.
> 
> Reported-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> Signed-off-by: Alexander Duyck <aduyck@...antis.com>

Applied and queued up for -stable, thanks Alex.