netdev - Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0362A89D-78DF-4F09-A8B6-5A87FAA74AB9@gmail.com>
Date:	Wed, 10 Feb 2016 10:13:56 +0100
From:	John Holland <jotihojr@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob




Sent from my iPad
On Feb 9, 2016, at 12:54, Andrew Lunn <andrew@...n.ch> wrote:

>>> +static void igb_read_mac_addr_dts(struct e1000_hw *hw)
>>> +{
>>> +       const u8 *mac;
>>> +       struct device_node *dn;
>>> +
>>> +       dn = of_find_compatible_node(NULL, NULL, "intel,i211");
> 
> Hi John
> 
> Would this also work for the i210?

The usability scenario of i210 and i211 seem similar enough. Although, I will not be able to test the i210, I will use it as the compatible keyword.

> 
> If so, you normally use the compatible string for the first device
> this works with. So maybe this should be changed to intel,i210?
> 
> Thanks
>    Andrew