netdev - Re: [PATCH net-next v3 6/7] soreuseport: fast reuseport TCP socket selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160210.060235.2264036197106612193.davem@davemloft.net>
Date:	Wed, 10 Feb 2016 06:02:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	kraigatgoog@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 6/7] soreuseport: fast reuseport TCP socket
 selection

From: Craig Gallek <kraigatgoog@...il.com>
Date: Tue,  9 Feb 2016 19:19:01 -0500

> diff --git a/net/ipv6/inet6_hashtables.c b/net/ipv6/inet6_hashtables.c
> index 19913e9e09e0..1ec87f62bdd7 100644
> --- a/net/ipv6/inet6_hashtables.c
> +++ b/net/ipv6/inet6_hashtables.c
 ...
> @@ -283,7 +297,7 @@ int inet6_hash(struct sock *sk)
>  {
>  	if (sk->sk_state != TCP_CLOSE) {
>  		local_bh_disable();
> -		__inet_hash(sk, NULL);
> +		__inet_hash(sk, NULL, ipv6_rcv_saddr_equal);
>  		local_bh_enable();
>  	}
>  
> -- 
> 2.7.0.rc3.207.g0ac5344
> 

You cannot invoke 'm' code (net/ipv6/udp.c:ipv6_rcv_saddr_equal) from 'y'
code (net/ipv6/inet6_hashtables.c:inet6_hash).