netdev - Re: [PATCH net-next 1/2] nsh: encapsulation module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Feb 2016 19:54:51 +0000
From:	Brian Russell <brian.russell@...cade.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] nsh: encapsulation module



On 11/02/16 16:39, David Miller wrote:
> From: Brian Russell <brussell@...cade.com>
> Date: Thu, 11 Feb 2016 10:35:13 +0000
> 
>> +++ b/include/net/nsh.h
>> +struct nsh_metadata {
>> +	u_short class;
>> +	u_char crit;
>> +	u_char type;
>> +	u_int len;  /* 4 byte words */
>> +	void *data;
> 
> Do not use these shorthands, spell out "unsigned short" etc. explicitly.
> 
> But in these cases you should be using fixed sized types like "u16".
> 
> Also, in a header file such as this one which is private to the kernel
> you should be using the variants of these types without the leading underscores.
> 

Ok, will fix those up.

Thanks,

Brian