netdev - Re: [PATCH] iwlwifi: fix erroneous return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB32EA0DC45@hasmsx107.ger.corp.intel.com>
Date:	Thu, 11 Feb 2016 06:36:33 +0000
From:	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
To:	Anton Protopopov <a.s.protopopov@...il.com>,
	"Berg, Johannes" <johannes.berg@...el.com>,
	Kalle Valo <kvalo@...eaurora.org>,
	Eran Harary <eran.harary@...el.com>
CC:	linuxwifi <linuxwifi@...el.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: fix erroneous return value



On 02/10/2016 07:10 PM, Anton Protopopov wrote:
> The iwl_trans_pcie_start_fw() function may return the positive value EIO
> instead of -EIO in case of error.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@...il.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> index d60a467..920ea9d 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> @@ -1034,7 +1034,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans,
>  	if (trans_pcie->is_down) {
>  		IWL_WARN(trans,
>  			 "Can't start_fw since the HW hasn't been started\n");
> -		ret = EIO;
> +		ret = -EIO;
>  		goto out;
>  	}
>  

applied - thanks.