netdev - Re: [PATCH v3] openvswitch: allow management from inside user namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_CLkirGUf4r=0pyJppaKgbV7nm8u5guXcM=sdup2YJCnA@mail.gmail.com>
Date:	Thu, 11 Feb 2016 10:10:59 +0100
From:	pravin shelar <pshelar@....org>
To:	Tycho Andersen <tycho.andersen@...onical.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org,
	Eric Biederman <ebiederm@...ssion.com>,
	Justin Pettit <jpettit@...ira.com>
Subject: Re: [PATCH v3] openvswitch: allow management from inside user namespaces

On Fri, Feb 5, 2016 at 5:20 PM, Tycho Andersen
<tycho.andersen@...onical.com> wrote:
> Operations with the GENL_ADMIN_PERM flag fail permissions checks because
> this flag means we call netlink_capable, which uses the init user ns.
>
> Instead, let's introduce a new flag, GENL_UNS_ADMIN_PERM for operations
> which should be allowed inside a user namespace.
>
> The motivation for this is to be able to run openvswitch in unprivileged
> containers. I've tested this and it seems to work, but I really have no
> idea about the security consequences of this patch, so thoughts would be
> much appreciated.
>
> v2: use the GENL_UNS_ADMIN_PERM flag instead of a check in each function
> v3: use separate ifs for UNS_ADMIN_PERM and ADMIN_PERM, instead of one
>     massive one
>
> Reported-by: James Page <james.page@...onical.com>
> Signed-off-by: Tycho Andersen <tycho.andersen@...onical.com>
> CC: Eric Biederman <ebiederm@...ssion.com>
> CC: Pravin Shelar <pshelar@....org>
> CC: Justin Pettit <jpettit@...ira.com>
> CC: "David S. Miller" <davem@...emloft.net>
> ---
>  include/uapi/linux/genetlink.h |  1 +
>  net/netlink/genetlink.c        |  4 ++++
>  net/openvswitch/datapath.c     | 20 ++++++++++----------
>  3 files changed, 15 insertions(+), 10 deletions(-)
>
Looks good.

Acked-by: Pravin B Shelar <pshelar@....org>